[asterisk-dev] [Code Review] Dialplan function for manager account checks - AMI_CLIENT()

Olle E Johansson oej at edvina.net
Tue Nov 3 14:49:05 CST 2009



> On 2009-11-03 13:35:39, Joshua Colp wrote:
> > /trunk/main/manager.c, line 5533
> > <https://reviewboard.asterisk.org/r/421/diff/1/?file=7272#file7272line5533>
> >
> >     Since this exists in the core you need to call:
> >     
> >     __ast_custom_function_register(&managerclient_function, NULL);
> >     
> >     Which will disable automatic module reference counting. ast_custom_function_register is actually there so that modules have the right thing happen automatically.

THANK YOU!

Branch updated and tested. It works as expected.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/421/#review1239
-----------------------------------------------------------


On 2009-11-03 14:48:56, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/421/
> -----------------------------------------------------------
> 
> (Updated 2009-11-03 14:48:56)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Implementation of a dialplan function for checking manager accounts. I've made it extensible so that we can add other parameters when needed. Right now it only checks the number of logged in sessions for a manager account.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/manager.c 227348 
> 
> Diff: https://reviewboard.asterisk.org/r/421/diff
> 
> 
> Testing
> -------
> 
> Tested on my Linux system and it reports manager logins properly - 0, 1 and 2 concurrent sessions...
> 
> 
> Thanks,
> 
> Olle E
> 
>




More information about the asterisk-dev mailing list