[asterisk-dev] [Code Review] better SDP parsing algorithm for 1.4

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/385/
-----------------------------------------------------------

(Updated 2009-11-02 14:59:39.051325)


Review request for Asterisk Developers, Olle E Johansson and Matthew Nicholson.


Changes
-------

Added a session level ast_hostent structure as jcolp suggested.


Summary
-------

This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).

If ported to 1.6 (sorry but I have no idea how the SIP code changed between 1.4 and 1.6 so I don't know how to do it), it will allow to easily add SDP functionality.


This addresses bug 0014994.
    https://issues.asterisk.org/view.php?id=0014994


Diffs (updated)
-----

  /branches/1.4/channels/chan_sip.c 226751 

Diff: https://reviewboard.asterisk.org/r/385/diff


Testing
-------

Production tested for multiple audio and video devices in a version of the patch for 1.4.26.2 (see bug #14994).

Not tested with T.38, but it should work well.


Thanks,

frawd