[asterisk-dev] [Code Review] Simplify the Makefile to avoid listing every file inside main/
Sean Bright
sean.bright at gmail.com
Fri May 29 14:19:12 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/269/#review807
-----------------------------------------------------------
Ship it!
Looks good to me other than a very very minor point. Nice work!
/trunk/main/Makefile
<http://reviewboard.digium.com/r/269/#comment1993>
A little nitpicky, but I'd call this OBJSFILTER or FILTEROBJ
- Sean
On 2009-05-29 13:55:22, Eliel Sardañons wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/269/
> -----------------------------------------------------------
>
> (Updated 2009-05-29 13:55:22)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> The idea is to remove all the list of objects files to be compiled & linked and make "make" :) generate the list for us.
>
>
> Diffs
> -----
>
> /trunk/main/Makefile 197957
>
> Diff: http://reviewboard.digium.com/r/269/diff
>
>
> Testing
> -------
>
> asterisk compiles.
>
>
> Thanks,
>
> Eliel
>
>
More information about the asterisk-dev
mailing list