[asterisk-dev] [Code Review] Remove dead code in chan_agent

[Eliel Sardañons]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/267/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

AgentCallbacklogin was deprecated, but a lot of code regarding that functionality wasn't removed.
Agents are dump in the astdb only if there are logged in with AgentCallbacklogin (not used code).
ackcall could have three values:
ackcall=yes, ackcall=always and ackcall=no Now it is not needed anymore leave always for backward compatibility but make 'yes' work like 'always'.
It is not needed anymore to load agents from the astdb because we are not saving them.
loginchan is being used only by AgentCallbacklogin, is the user is logged with AgentLogin then loginchan is NULL.


Diffs
-----

  /trunk/channels/chan_agent.c 197925 
  /trunk/configs/agents.conf.sample 197925 

Diff: http://reviewboard.digium.com/r/267/diff


Testing
-------

Login an agent, receive a call from a queue with and without the ackcall option setted.


Thanks,

Eliel