[asterisk-dev] [Code Review] New signaling module to handle analog operations in chan_dahdi

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/253/#review796
-----------------------------------------------------------



/trunk/channels/Makefile
<http://reviewboard.digium.com/r/253/#comment1980>

    This isn't quite right for our build system.  Take a look at the chan_iax2 example for how to add sig_analog to the build.



/trunk/channels/sig_analog.h
<http://reviewboard.digium.com/r/253/#comment1981>

    Update the copyright headers in the new files to match those in other Asterisk files.


- Russell


On 2009-05-22 13:00:28, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/253/
> -----------------------------------------------------------
> 
> (Updated 2009-05-22 13:00:28)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This branch splits all the analog signaling logic out of chan_dahdi.c into sig_analog.c. Functionality in theory should not change at all.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/Makefile 196274 
>   /trunk/channels/chan_dahdi.c 196274 
>   /trunk/channels/sig_analog.h PRE-CREATION 
>   /trunk/channels/sig_analog.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/253/diff
> 
> 
> Testing
> -------
> 
> The main testing I did was simply making calls. Once I got that working most everything else seemed to work. Specifically made sure caller id works for both sending and receiving as well.
> 
> 
> Thanks,
> 
> Jeff
> 
>