[asterisk-dev] [Code Review] Calendaring API for Asterisk

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/58/#review758
-----------------------------------------------------------

Ship it!


After this last set of comments, I say we merge this bad boy into trunk!  We can continue to work on things there if needed.

Nice work, Terry!


/trunk/configs/calendar.conf.sample
<http://reviewboard.digium.com/r/58/#comment1913>

    If you would like the functionality enabled by default, then I would just make it that way in the code, so it's that way even if you don't have a config file.
    
    However, is "enabled" really necessary?  Wouldn't the definition of calendars in this file imply that it is enabled?



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1914>

    This is actually a static number of buckets, not a maximum.



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1915>

    I'm a little bit concerned with this part.  A thread is created and given a pointer to the cal object.  However, the reference count does not reflect that another thread now holds a reference to it, meaning that it is theoretically possible that it could disappear when you don't want it to.
    
    Also, if you change this, be careful not to leak a reference in the case that the thread fails to start.



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1916>

    I don't think the cast is necessary here.



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1917>

    This is a superfluous return.



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1918>

    An error will be logged for you if this happens.



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1919>

    An error will be logged for you.



/trunk/main/calendar.c
<http://reviewboard.digium.com/r/58/#comment1920>

    An error will be logged for you.


- Russell


On 2009-03-17 12:16:17, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/58/
> -----------------------------------------------------------
> 
> (Updated 2009-03-17 12:16:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Calendaring integration for Asterisk--currently supporting iCalendar files (hosted over HTTP/HTTPS), CalDAV, and Microsoft Exchange.  Features available: dialplan functions for querying and writing (if the calendar technology supports it like CalDAV and Exchange do) calendar event information, a device state provider for phone BLF support, and calendar event notification through executing dialplan apps or context/exten.
> 
> The overall structure is that the res_* calendar modules register as a calendar tech to main/calendar.c, and after all modules are loaded, main/calendar.c parses calendar.conf and calls the calendar_load callback for each register calendar tech based on the "type" field for that calendar in calendars.conf.  Currently each calendar runs in its own thread downloading and refreshing the remote calendar data as necessary as to avoid serializing downloads.  
> 
> Eventually it would probably be a good idea for me to implement a thread pool and honor a maximum number of downloads per host:port as well as a global maximum number of simultaneous downloads--perhaps with a min/max refresh value so I could randomize the time for refreshing a bit so as not to be refreshing all of the calendars at once.  Also, there was a request to add support for the dialplan functions to query calendars that aren't in calendar.conf i.e. CALENDAR_QUERY(ical/http://www.google.com/calendar/ical/nkt5atdq7cdbes3ehdfpendpnc%40group.calendar.google.com/public/basic.ics,${EPOCH},$[${EPOCH} + 3600]), etc.
> 
> Currently I don't have any support for querying/setting attendees, mostly because it is a list of results whereas all of the others are individual fields.  Writing gets especially ugly for them because of the current format of CALENDAR_WRITE(calendar,${HASHKEYS(calendar)})=${HASH(calendar)}.  I suppose I could add a ...,${HAHSKEYS(attendees)})=...,${HASH(attendees)} to the end...it is just getting a little ugly.
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 182567 
>   /trunk/configs/calendar.conf.sample PRE-CREATION 
>   /trunk/configure.ac 182567 
>   /trunk/include/asterisk/_private.h 182567 
>   /trunk/include/asterisk/autoconfig.h.in 182567 
>   /trunk/include/asterisk/calendar.h PRE-CREATION 
>   /trunk/main/Makefile 182567 
>   /trunk/main/asterisk.c 182567 
>   /trunk/main/calendar.c PRE-CREATION 
>   /trunk/main/loader.c 182567 
>   /trunk/makeopts.in 182567 
>   /trunk/res/res_caldav.c PRE-CREATION 
>   /trunk/res/res_exchangecal.c PRE-CREATION 
>   /trunk/res/res_icalendar.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/58/diff
> 
> 
> Testing
> -------
> 
> I have tested all three calendar modules by adding, deleting, and moving events and verifying that notifications occur.  I have tested writing to Exchange, and Zimbra and Google Calendar through CalDAV.  I have run with MALOC_DEBUG looking for leaks and dropped references to astobj2 objects. 
> 
> 
> Thanks,
> 
> Terry
> 
>