[asterisk-dev] [Code Review] XML documentation for manager actions.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/250/#review784
-----------------------------------------------------------



/trunk/include/asterisk/agi.h
<http://reviewboard.digium.com/r/250/#comment1963>

    This looks like an unrelated change.
    
    Also, I would prefer that we don't do this.  This will make the ABI change depending on whether you compiled with XML docs support or not.  This seems unnecessary.



/trunk/include/asterisk/manager.h
<http://reviewboard.digium.com/r/250/#comment1964>

    Same comment about this ifdef, as for the one in agi.h



/trunk/include/asterisk/pbx.h
<http://reviewboard.digium.com/r/250/#comment1965>

    Same ifdef comment



/trunk/include/asterisk/xmldoc.h
<http://reviewboard.digium.com/r/250/#comment1966>

    Then, here, this should be defined always.


- Russell


On 2009-05-14 10:44:26, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/250/
> -----------------------------------------------------------
> 
> (Updated 2009-05-14 10:44:26)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> With this patch we allow to set manager actions documentation in xml format like we are already doing for applications/functions and agi commands.
> It is possible to use both type of documentations (static and xml).
> 
> 
> Diffs
> -----
> 
>   /trunk/main/pbx.c 194213 
>   /trunk/main/xmldoc.c 194213 
>   /trunk/res/res_agi.c 194213 
>   /trunk/include/asterisk/xmldoc.h 194213 
>   /trunk/main/manager.c 194283 
>   /trunk/doc/appdocsxml.dtd 194213 
>   /trunk/include/asterisk/agi.h 194213 
>   /trunk/include/asterisk/manager.h 194213 
>   /trunk/include/asterisk/pbx.h 194213 
> 
> Diff: http://reviewboard.digium.com/r/250/diff
> 
> 
> Testing
> -------
> 
> The patch was tested with xmldoc enabled and without xmldoc enabled (./configure --disable-xmldoc).
> 'core show application ....' -> tested
> 'core show function ...' -> tested
> 'agi show commands topic ...' -> tested
> 
> 'manager show commands' -> tested
> 'manager show command Ping' -> tested
> 'manager show command Events' -> tested
> 
> 
> Thanks,
> 
> Eliel
> 
>