[asterisk-dev] [Code Review] Fix issue #15088 and #14974, also fixes many AMI bugs related to astobj2

Mark Michelson mmichelson at digium.com
Tue May 12 15:36:47 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/#review773
-----------------------------------------------------------


You added a mutex in here and several calls to ast_mutex_init. However, you did not add any calls to ast_mutex_destroy.

- Mark


On 2009-05-12 14:59:29, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/248/
> -----------------------------------------------------------
> 
> (Updated 2009-05-12 14:59:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch fixes an issue in the AMI that when logging out makes asterisk crash.
> Also there where many warning messages related to astobj2, this warnings where caused while trying to lock a mansession (that is not an astob2), so the mansession was never being locked.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/manager.c 193868 
> 
> Diff: http://reviewboard.digium.com/r/248/diff
> 
> 
> Testing
> -------
> 
> Developer testing, and reports by mnicholson and me that the two issues are being fixed.
> 
> 
> Thanks,
> 
> Eliel
> 
>




More information about the asterisk-dev mailing list