[asterisk-dev] expected hint value when multiple devices are combined (onHold)

[Philippe Lindheimer]

Thanks Russell,

I filed a bug and created a proposed patch:

http://bugs.digium.com/view.php?id=15057

the 1.4 patch is tested and seems to work. The trunk patch should be ok but I don't have a system to build and test it against at the moment.

--- On Thu, 5/7/09, Russell Bryant <russell at digium.com> wrote:
From: Russell Bryant <russell at digium.com>
Subject: Re: [asterisk-dev] expected hint value when multiple devices are combined (onHold)
To: p_lindheimer at yahoo.com, "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Date: Thursday, May 7, 2009, 6:17 PM

On May 7, 2009, at 4:27 PM, Philippe Lindheimer wrote:

> OnHold & Idle = Idle  (NOT WHAT ONE WOULD EXPECT)
> 
> I conjecture that one would expect any state that 'raises' the
level of the combination above an idle state would return that state, and
basically the 'less available'  (busier so to speak) that the state is,
it would take precedence. Most of the behavior appears that way with the
exception that Idle is taking precedence of onHold which seems very
counter-intuitive.
> 
> Before filing this as a "bug" I would like to get the feedback
of others what would be the proper value of such a combination.


I would agree that this is a bug.  I would expect that combination of states to
result in an OnHold state.

The fix should be relatively easy.  The responsible code is in
ast_extension_state2() of main/pbx.c in Asterisk 1.4.

In Asterisk trunk, the same logic was moved into some common code.  Search for
ast_devstate_aggregate in main/devicestate.c.

--
Russell Bryant
Digium, Inc. | Senior Software Engineer, Open Source Team Lead
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org







      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20090507/5503f474/attachment.htm