[asterisk-dev] [Code Review] CLI command 'manager logout <username> [from <ipaddress>]'

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/77/#review770
-----------------------------------------------------------



/trunk/main/manager.c
<http://reviewboard.digium.com/r/77/#comment1936>

    What's the reason for moving this code to later?



/trunk/main/manager.c
<http://reviewboard.digium.com/r/77/#comment1937>

    Why wait only half a second here?



/trunk/main/manager.c
<http://reviewboard.digium.com/r/77/#comment1938>

    If the loggedoff flag is set, shouldn't you set res to something else?


- Tilghman


On 2009-02-20 19:31:37, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/77/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 19:31:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> CLI command 'manager logout <username> [from <ipaddress>]' as discussed on the mailing list (-dev).
> Please review twice the way I am logging out the user (how I am using the locks).
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 177785 
>   /trunk/main/manager.c 177785 
> 
> Diff: http://reviewboard.digium.com/r/77/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>