[asterisk-dev] [Code Review] Add 'bitflags' IE payload type to events framework

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/242/#review763
-----------------------------------------------------------



/trunk/main/event.c
<http://reviewboard.digium.com/r/242/#comment1927>

    I don't think this is quite right.
    
    If I say "check for subscribers to events with IE foo and bitflag A", and there is a subscriber to events with IE foo and bitflags A and B, this will consider it as not a match, where I think it should match.
    
    I think the "!= sub_ie_val->payload.uint" should be "!= ie_val->payload.uint".


- Russell


On 2009-05-03 01:03:19, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/242/
> -----------------------------------------------------------
> 
> (Updated 2009-05-03 01:03:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a 'bitflags' IE payload type for events in the events framework; the payload is actually a 32-bit unsigned integer, but when matching payload values during subscription a bit-wise AND is used for the comparison instead of comparing the payload values.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/event.c 191883 
>   /trunk/include/asterisk/event_defs.h 191883 
>   /trunk/include/asterisk/event.h 191883 
> 
> Diff: http://reviewboard.digium.com/r/242/diff
> 
> 
> Testing
> -------
> 
> Compile testing only at this time.
> 
> 
> Thanks,
> 
> Kevin
> 
>