[asterisk-dev] [Code Review] DTMF no wait after last digit

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/210/#review630
-----------------------------------------------------------

Ship it!


Aside from the formatting thing Mark pointed out, this looks fine.

- Russell


On 2009-03-26 14:46:58, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/210/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 14:46:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ast_dtmf_stream() does a quick 100ms pause between every digit.  That pause is done after the last digit as well, which doesn't make sense to me.  I put a check before the ast_safe_sleep to make sure its only executed if it is not the last digit.  I found this because it screws up the timing in app_test.c.  
> 
> app_test.c has a bunch of formatting changes.  this file is very rarely changed so I don't see why this should be a problem. 
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_test.c 183994 
>   /trunk/main/app.c 183994 
> 
> Diff: http://reviewboard.digium.com/r/210/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>