[asterisk-dev] [Code Review] DTMF no wait after last digit
David Vossel
dvossel at digium.com
Thu Mar 26 14:46:58 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/210/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
ast_dtmf_stream() does a quick 100ms pause between every digit. That pause is done after the last digit as well, which doesn't make sense to me. I put a check before the ast_safe_sleep to make sure its only executed if it is not the last digit. I found this because it screws up the timing in app_test.c.
app_test.c has a bunch of formatting changes. this file is very rarely changed so I don't see why this should be a problem.
Diffs
-----
/trunk/apps/app_test.c 183994
/trunk/main/app.c 183994
Diff: http://reviewboard.digium.com/r/210/diff
Testing
-------
Thanks,
David
More information about the asterisk-dev
mailing list