[asterisk-dev] [Code Review] Merge Called party identification changes into trunk.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/201/
-----------------------------------------------------------

(Updated 2009-03-24 17:03:09.146312)


Review request for Asterisk Developers.


Changes
-------

All right. New diff uploaded. I have Russell's blessings to merge to trunk, but I thought I'd give others an opportunity to give their opinions on the matter so I'll hold off on merging this for at least a little while longer.


Summary
-------

This diff encompasses the changes between the issue8824 branch and Asterisk trunk. These changes include all the changes necessary to allow for the transmission and reception of remote called party identification (COLP/CONP).


This addresses bug 8824.
    http://bugs.digium.com/view.php?id=8824


Diffs (updated)
-----

  /trunk/apps/app_dial.c 183985 
  /trunk/apps/app_directed_pickup.c 183985 
  /trunk/apps/app_queue.c 183985 
  /trunk/channels/chan_agent.c 183985 
  /trunk/channels/chan_dahdi.c 183985 
  /trunk/channels/chan_h323.c 183985 
  /trunk/channels/chan_iax2.c 183985 
  /trunk/channels/chan_local.c 183985 
  /trunk/channels/chan_mgcp.c 183985 
  /trunk/channels/chan_misdn.c 183985 
  /trunk/channels/chan_phone.c 183985 
  /trunk/channels/chan_sip.c 183985 
  /trunk/channels/chan_skinny.c 183985 
  /trunk/channels/chan_unistim.c 183985 
  /trunk/channels/misdn/chan_misdn_config.h 183985 
  /trunk/channels/misdn/isdn_lib.h 183985 
  /trunk/channels/misdn/isdn_lib.c 183985 
  /trunk/channels/misdn/isdn_lib_intern.h 183985 
  /trunk/channels/misdn/isdn_msg_parser.c 183985 
  /trunk/channels/misdn_config.c 183985 
  /trunk/configs/misdn.conf.sample 183985 
  /trunk/configs/sip.conf.sample 183985 
  /trunk/funcs/func_connectedline.c PRE-CREATION 
  /trunk/funcs/func_redirecting.c PRE-CREATION 
  /trunk/include/asterisk/callerid.h 183985 
  /trunk/include/asterisk/channel.h 183985 
  /trunk/include/asterisk/frame.h 183985 
  /trunk/main/callerid.c 183985 
  /trunk/main/channel.c 183985 
  /trunk/main/dial.c 183985 
  /trunk/main/features.c 183985 
  /trunk/main/rtp.c 183985 

Diff: http://reviewboard.digium.com/r/201/diff


Testing
-------

Digium's Product Quality department has extensively tested a remarkably similar version of these enhancements. In addition, we know of a customer who has been using this branch for some months now in a production environment. I would also be willing to bet that some of those who have been monitoring issue 8824 have also done some testing as well.


Thanks,

Mark