[asterisk-dev] [Code Review] SIP Preferred codec only

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/206/#review613
-----------------------------------------------------------

Ship it!


Code looks good! Much simpler then I expected. Once you have the documentation this has a thumbs up from me.

- Joshua


On 2009-03-24 14:02:50, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/206/
> -----------------------------------------------------------
> 
> (Updated 2009-03-24 14:02:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added an option to respond to a SIP invite with only the single most preferred joint codec.  This limits the options of what codecs the other side can use. 
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 183697 
> 
> Diff: http://reviewboard.digium.com/r/206/diff
> 
> 
> Testing
> -------
> 
> tested with preferred_codec_only enabled in sip.conf.  Scanned wireshark log to make sure only the most preferred codec was sent in response to an INVITE. 
> 
> 
> Thanks,
> 
> David
> 
>