[asterisk-dev] [Code Review] Merge Called party identification changes into trunk.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/201/#review595
-----------------------------------------------------------



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1474>

    This appears to be an unrelated documentation change.



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1475>

    still have unrelated formatting changes here.



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1476>

    This section needs some channel locking love



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1477>

    This section needs some channel locking love



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1478>

    Need some channel locking here



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1479>

    channel locking



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1480>

    Both channels must be locked during this operation.



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1481>

    This is another tricky section that has some missing channel locking.
    
    ast_set_callerid() will lock the channel provided as the first argument.  However, if you're going to read fields directly from another channel, that channel must be locked, as well.



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/201/#comment1482>

    channel locking


- Russell


On 2009-03-23 09:52:15, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/201/
> -----------------------------------------------------------
> 
> (Updated 2009-03-23 09:52:15)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This diff encompasses the changes between the issue8824 branch and Asterisk trunk. These changes include all the changes necessary to allow for the transmission and reception of remote called party identification (COLP/CONP).
> 
> 
> This addresses bug 8824.
>     http://bugs.digium.com/view.php?id=8824
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 183691 
>   /trunk/apps/app_directed_pickup.c 183691 
>   /trunk/apps/app_queue.c 183691 
>   /trunk/channels/chan_agent.c 183691 
>   /trunk/channels/chan_dahdi.c 183691 
>   /trunk/channels/chan_h323.c 183691 
>   /trunk/channels/chan_iax2.c 183691 
>   /trunk/channels/chan_local.c 183691 
>   /trunk/channels/chan_mgcp.c 183691 
>   /trunk/channels/chan_misdn.c 183691 
>   /trunk/channels/chan_phone.c 183691 
>   /trunk/channels/chan_sip.c 183691 
>   /trunk/channels/chan_skinny.c 183691 
>   /trunk/channels/chan_unistim.c 183691 
>   /trunk/channels/misdn/chan_misdn_config.h 183691 
>   /trunk/channels/misdn/isdn_lib.h 183691 
>   /trunk/channels/misdn/isdn_lib.c 183691 
>   /trunk/channels/misdn/isdn_lib_intern.h 183691 
>   /trunk/channels/misdn/isdn_msg_parser.c 183691 
>   /trunk/channels/misdn_config.c 183691 
>   /trunk/configs/misdn.conf.sample 183691 
>   /trunk/configs/sip.conf.sample 183691 
>   /trunk/funcs/func_connectedline.c PRE-CREATION 
>   /trunk/funcs/func_redirecting.c PRE-CREATION 
>   /trunk/include/asterisk/callerid.h 183691 
>   /trunk/include/asterisk/channel.h 183691 
>   /trunk/include/asterisk/frame.h 183691 
>   /trunk/main/callerid.c 183691 
>   /trunk/main/channel.c 183691 
>   /trunk/main/dial.c 183691 
>   /trunk/main/features.c 183691 
>   /trunk/main/rtp.c 183691 
> 
> Diff: http://reviewboard.digium.com/r/201/diff
> 
> 
> Testing
> -------
> 
> Digium's Product Quality department has extensively tested a remarkably similar version of these enhancements. In addition, we know of a customer who has been using this branch for some months now in a production environment. I would also be willing to bet that some of those who have been monitoring issue 8824 have also done some testing as well.
> 
> 
> Thanks,
> 
> Mark
> 
>