[asterisk-dev] [Code Review] Convert ast_channel over to astobj2

Russell Bryant russell at digium.com
Fri Mar 20 07:30:25 CDT 2009 


> On 2009-03-20 03:44:07, vadim wrote:
> >

Thanks for the review, vadim!


> On 2009-03-20 03:44:07, vadim wrote:
> > /trunk/apps/app_directed_pickup.c, line 143
> > <http://reviewboard.digium.com/r/203/diff/1/?file=3299#file3299line143>
> >
> >     Why the ast_channel_get_by_name_prefix can't be used here instead of iterator stuff?

We can't, actually, because of the need to check for the things done in can_pickup().


> On 2009-03-20 03:44:07, vadim wrote:
> > /trunk/apps/app_directed_pickup.c, line 151
> > <http://reviewboard.digium.com/r/203/diff/1/?file=3299#file3299line151>
> >
> >     forgotten: ast_channel_iterator_destroy(iter);

Fixed


> On 2009-03-20 03:44:07, vadim wrote:
> > /trunk/apps/app_directed_pickup.c, line 201
> > <http://reviewboard.digium.com/r/203/diff/1/?file=3299#file3299line201>
> >
> >     can't we use ast_channel_get_by_exten() here?

We can't because of the need to do the can_pickup() logic.


> On 2009-03-20 03:44:07, vadim wrote:
> > /trunk/apps/app_directed_pickup.c, line 211
> > <http://reviewboard.digium.com/r/203/diff/1/?file=3299#file3299line211>
> >
> >     do you mean:
> >       ast_channel_unlock(chan);   ?

Definitely a bug, fixed!


> On 2009-03-20 03:44:07, vadim wrote:
> > /trunk/main/autochan.c, line 1
> > <http://reviewboard.digium.com/r/203/diff/1/?file=3319#file3319line1>
> >
> >     I would suggest that instead of using one global autochan list to we could use autochan list head in the channel structure itself.
> >     
> >     This will surely be more efficient

I'll let Mark comment on this, since the autochan stuff was his work.


> On 2009-03-20 03:44:07, vadim wrote:
> > /trunk/res/snmp/agent.c, line 596
> > <http://reviewboard.digium.com/r/203/diff/1/?file=3330#file3330line596>
> >
> >     I wonder if we really need to lock the channel here? Can channel technology change during channel lifetime?
> >     
> >     Btw in ast_raw_answer i see access to the chan->tech without lock.

To answer your first question, no, we do not actually need the channel locked here.  So, I will remove it.

As to the second question, yes, the channel technology can change.  The only place that happens is in ast_do_masquerade(), but that can happen at any point in a channel's lifetime.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/203/#review582
-----------------------------------------------------------


On 2009-03-19 16:41:26, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/203/
> -----------------------------------------------------------
> 
> (Updated 2009-03-19 16:41:26)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch converts handling of the ast_channel data structure over to the astobj2 framework.  There is a lot that could be said about this, but the patch is a bit improvement for performance, stability, code maintainability, and ease of future code development.
> 
> The channel list is no longer an unsorted linked list.  The main container for channels is an astobj2 hash table.  All of the code related to searching for channels or iterating active channels has been rewritten.  Let n be the number of active channels.  Iterating the channel list has gone from O(n^2) to O(n).  Searching for a channel by name went from O(n) to O(1).  Searching for a channel by extension is still O(n), but uses a new method for doing so, which is more efficient.
> 
> The ast_channel object is now a reference counted object.  The benefits here are plentiful.  Some benefits directly related to issues in the previous code include:
> 
> 1) When threads other than the channel thread owning a channel wanted access to a channel, it had to acquire from the channel list and hold the lock on it to ensure that it didn't go away.  This is no longer a requirement.  Holding a reference is sufficient.
> 
> 2) There are places that now require less dealing with channel locks.
> 
> 3) There are places where channel locks are held for much shorter periods of time.
> 
> 4) There are places where dealing with more than one channel at a time becomes _MUCH_ easier.  ChanSpy is a great example of this.  Writing code in the future that deals with multiple channels will be much easier.
> 
> Some additional information regarding channel locking and reference count handling can be found in channel.h, where a new section has been added that discusses some of the rules associated with it.
> 
> Mark Michelson also assisted with the development of this patch.  He did the conversion of ChanSpy and introduced a new API, ast_autochan, which makes it much easier to deal with holding on to a channel pointer for an extended period of time and having it get automatically updated if the channel gets masqueraded.
> 
> One final note is that currently, app_dahdichan will not compile.  I just haven't been motivated enough to do it.  Everything else should be good to go, though.  I think the best thing to do is to just add whatever is necessary to ChanSpy to allow DAHDIChan to become a wrapper for ChanSpy.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_channelredirect.c 183442 
>   /trunk/apps/app_chanspy.c 183442 
>   /trunk/apps/app_dahdiscan.c 183442 
>   /trunk/apps/app_directed_pickup.c 183442 
>   /trunk/apps/app_minivm.c 183442 
>   /trunk/apps/app_mixmonitor.c 183442 
>   /trunk/apps/app_senddtmf.c 183442 
>   /trunk/apps/app_softhangup.c 183442 
>   /trunk/apps/app_voicemail.c 183442 
>   /trunk/channels/chan_agent.c 183442 
>   /trunk/channels/chan_bridge.c 183442 
>   /trunk/channels/chan_gtalk.c 183442 
>   /trunk/channels/chan_iax2.c 183442 
>   /trunk/channels/chan_local.c 183442 
>   /trunk/channels/chan_sip.c 183442 
>   /trunk/funcs/func_channel.c 183442 
>   /trunk/funcs/func_global.c 183442 
>   /trunk/funcs/func_logic.c 183442 
>   /trunk/funcs/func_odbc.c 183442 
>   /trunk/include/asterisk/autochan.h PRE-CREATION 
>   /trunk/include/asterisk/channel.h 183442 
>   /trunk/include/asterisk/lock.h 183442 
>   /trunk/main/Makefile 183442 
>   /trunk/main/autochan.c PRE-CREATION 
>   /trunk/main/channel.c 183442 
>   /trunk/main/cli.c 183442 
>   /trunk/main/devicestate.c 183442 
>   /trunk/main/features.c 183442 
>   /trunk/main/logger.c 183442 
>   /trunk/main/manager.c 183442 
>   /trunk/main/pbx.c 183442 
>   /trunk/res/res_agi.c 183442 
>   /trunk/res/res_clioriginate.c 183442 
>   /trunk/res/res_monitor.c 183442 
>   /trunk/res/snmp/agent.c 183442 
> 
> Diff: http://reviewboard.digium.com/r/203/diff
> 
> 
> Testing
> -------
> 
> I've done some basic testing making calls, transfers, etc., and I know Mark has done some, too.  However, this is one of those patches that seems like you can never test it enough.
> 
> Basically, any usage of Asterisk is useful testing for this.
> 
> 
> Thanks,
> 
> Russell
> 
>

More information about the asterisk-dev mailing list