[asterisk-dev] [Code Review] Change T38 passthrough reinvite to use control frames

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/200/#review579
-----------------------------------------------------------

Ship it!



/branches/1.6.0/channels/chan_sip.c
<http://reviewboard.digium.com/r/200/#comment1399>

    As a general note, take care when porting to trunk and 1.6.1, as the scheduler entries must take into account reference count handling.


- Russell


On 2009-03-18 11:09:35, Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/200/
> -----------------------------------------------------------
> 
> (Updated 2009-03-18 11:09:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch changes the T38 passthrough reinvite method to use the existing T38 control frames. It also fixes an issue where T38 was accepted even though the remote side may be an application that was not aware of it.
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.0/channels/chan_sip.c 182170 
> 
> Diff: http://reviewboard.digium.com/r/200/diff
> 
> 
> Testing
> -------
> 
> The following scenarios have been tested:
> 
> T38 Capable Device -> Asterisk -> Regular Phone - This scenario failed with a 488 which was expected
> T38 Capable Device -> Asterisk -> T38 Capable Device - This scenario worked with T38 negotiated on both sides
> T38 Capable Device -> Asterisk running an application - This scenario failed with a 488 which was expected
> 
> 
> Thanks,
> 
> Joshua
> 
>