[asterisk-dev] [Code Review] Randomize IAX2 encryption padding

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/193/
-----------------------------------------------------------

(Updated 2009-03-13 11:58:28.590605)


Review request for Asterisk Developers and Russell Bryant.


Changes
-------

the padding is now randomized every time the encryption key is built, which means it will be re-randomized during keyrotation. 


Summary
-------

The 16-32 byte random padding at the beginning of an encrypted IAX2 frame turns out to not be all that random at all.  This patch calls ast_random to fill the padding buffer with random data.  The padding is randomized at the beginning of every encrypted call and for every encrypted retransmit frame.


Diffs (updated)
-----

  /trunk/channels/chan_iax2.c 181963 

Diff: http://reviewboard.digium.com/r/193/diff


Testing
-------

ran an encrypted call, everything worked as expected. 


Thanks,

David