[asterisk-dev] [Code Review] SRTP support for Asterisk

[Mark Michelson]

> On 2009-03-10 17:05:00, Mark Michelson wrote:
> > /trunk/channels/sdp_crypto.c, lines 145-146
> > <http://reviewboard.digium.com/r/191/diff/1/?file=3014#file3014line145>
> >
> >     Any idea what this is about?

Hmm, it occurs to me that you are probably the one who added the second comment and thus don't know what needs fixing...


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/191/#review537
-----------------------------------------------------------


On 2009-03-10 14:39:03, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/191/
> -----------------------------------------------------------
> 
> (Updated 2009-03-10 14:39:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> SRTP support for Asterisk using Sdescriptions. This has been sitting around for a while, so I figured that it should at least get some review.  Full description of setup at http://lists.digium.com/pipermail/asterisk-dev/2009-January/036029.html
> 
> 
> This addresses bug 5413.
>     http://bugs.digium.com/view.php?id=5413
> 
> 
> Diffs
> -----
> 
>   /trunk/CREDITS 180812 
>   /trunk/apps/app_dial.c 180812 
>   /trunk/build_tools/menuselect-deps.in 180812 
>   /trunk/channels/Makefile 180812 
>   /trunk/channels/chan_iax2.c 180812 
>   /trunk/channels/chan_sip.c 180812 
>   /trunk/channels/sdp_crypto.h PRE-CREATION 
>   /trunk/channels/sdp_crypto.c PRE-CREATION 
>   /trunk/channels/sip_srtp.h PRE-CREATION 
>   /trunk/channels/sip_srtp.c PRE-CREATION 
>   /trunk/configure.ac 180812 
>   /trunk/funcs/func_channel.c 180812 
>   /trunk/include/asterisk/aes_internal.h 180812 
>   /trunk/include/asterisk/autoconfig.h.in 180812 
>   /trunk/include/asterisk/rtp.h 180812 
>   /trunk/main/rtp.c 180812 
>   /trunk/makeopts.in 180812 
>   /trunk/res/res_srtp.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/191/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Terry
> 
>