[asterisk-dev] [Code Review] New feature: Add audio announce option to app_page.c (#14365)

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/188/
-----------------------------------------------------------

(Updated 2009-03-05 12:36:00.947729)


Review request for Asterisk Developers.


Summary
-------

I'm creating my 1st reviewboard entry, as tilghman suggests.
The following patch adds option 'A(x)' to app_page, to play an announce simultaneously in all paged phones and (caller's one) before conference bridge is activated. Something like this:

exten => **,1,SIPAddHeader(Alert-Info: Ring Answer) ; For Auto-answer in Polycom phones
exten => **,n,Page(SIP/100&SIP/101,qA(chime))

where 'chime' is an audio file with a typical "airport" announce.

To do this, I've added an option 'G(x)' to app_meetme.c, to play an arbitrary message when entering a conference (option CONFFLAG_INTROMSG). The big problem was that in trunk app_meetme has 31 flag options, so I've to change flag register to 64 bits and ALL code, to use *test64 flag tests (like app_dial.c), to add the 32'st option.

If this patch is not as useful as I think, almost it prepared app_meetme code to use > 32 options.


This addresses bug 14365.
    http://bugs.digium.com/view.php?id=14365


Diffs
-----

  /trunk/apps/app_meetme.c 180304 
  /trunk/apps/app_page.c 180304 

Diff: http://reviewboard.digium.com/r/188/diff


Testing
-------


Thanks,

dferrer