[asterisk-dev] [Code Review] Fix problems when RTP packet frame size is changed

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/184/#review519
-----------------------------------------------------------

Ship it!


Other than picky formatting comments, this looks sane to me.


/branches/1.4/include/asterisk/frame.h
<http://reviewboard.digium.com/r/184/#comment1212>

    I know the entire smoother API is not documented, but it would really awesome to have documentation for the new API call.  :-)



/branches/1.4/main/frame.c
<http://reviewboard.digium.com/r/184/#comment1213>

    Minor formatting complaints ... (even though I know this code was moved from somewhere else)
    
    The coding guidelines now recommend always using braces.  Also, there is one place missing some spaces: s->data+s->len



/branches/1.4/main/frame.c
<http://reviewboard.digium.com/r/184/#comment1214>

    I'm going to be a formatting nazi again.  Almost all places in Asterisk where we have multi-line comments, they are in the form:
    
    /*
     * stuff
     * and things
     * moo
     */
    



/branches/1.4/main/frame.c
<http://reviewboard.digium.com/r/184/#comment1215>

    '!!' is cool and all, but I wonder if "swap ? 1 : 0" would be more clear.


- Russell


On 2009-03-05 09:19:57, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/184/
> -----------------------------------------------------------
> 
> (Updated 2009-03-05 09:19:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> During some code analysis, I found that calling ast_rtp_codec_setpref() on an ast_rtp session does not work as expected; it does not adjust the smoother that may on the RTP session, in fact it summarily drops it, even if it has data in it, even if the current format's framing size has not changed. This is not good.
> 
> This patch changes this behavior, so that if the packetization size for the current format changes, any existing smoother is safely updated to use the new size, and if no smoother was present, one is created. A new API call for smoothers, ast_smoother_reconfigure(), was required to implement these changes.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/include/asterisk/frame.h 180363 
>   /branches/1.4/main/frame.c 180363 
>   /branches/1.4/main/rtp.c 180363 
> 
> Diff: http://reviewboard.digium.com/r/184/diff
> 
> 
> Testing
> -------
> 
> Compile testing only.
> 
> 
> Thanks,
> 
> Kevin
> 
>