[asterisk-dev] [Code Review] Make the parameter separator backward compatible, and error messages more consistent.

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/79/#review520
-----------------------------------------------------------


This looks like a good start to making this be consistent; do you have intentions to try to find the pbx_findapp() usages that Mark noted here?



/trunk/apps/app_dial.c
<http://reviewboard.digium.com/r/79/#comment1217>

    In each case where you are performing this operation, the 'syntax' variable is actually unnecessary (and the compiler will probably optimize it out), because you can just put the function call directly into the ast_log() argument list.


- Kevin


On 2008-12-09 11:14:57, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/79/
> -----------------------------------------------------------
> 
> (Updated 2008-12-09 11:14:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch implements an asterisk.conf [compat] option called app_delim, to make applications and functions parameter delimiter backward compatible. if app_delim < 1.5 then, then app/fun delimited should be | (pipe), otherwise it should be "," comma.
> Also there are a number of functions that where not using STANDARD_APP_ARG to parse the app/fun parameters, so, that was changed to use AST_STANDARD_APP_DELIM.
> When printing error messages, we where printing the "syntax" with a hardcoded parameter separator, now the syntax being printed is the one generated with the xml documentation, so the error messages will be consistent with the actual parameter separator, and also with the actual app/fun syntax.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 161945 
>   /trunk/apps/app_macro.c 161945 
>   /trunk/apps/app_meetme.c 161945 
>   /trunk/apps/app_readfile.c 161945 
>   /trunk/funcs/func_callerid.c 161945 
>   /trunk/funcs/func_cut.c 161945 
>   /trunk/funcs/func_env.c 161945 
>   /trunk/funcs/func_realtime.c 161945 
>   /trunk/funcs/func_strings.c 161945 
>   /trunk/include/asterisk/app.h 161945 
>   /trunk/include/asterisk/pbx.h 161945 
>   /trunk/main/pbx.c 161945 
>   /trunk/main/xmldoc.c 161945 
>   /trunk/pbx/pbx_lua.c 161945 
> 
> Diff: http://reviewboard.digium.com/r/79/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>