[asterisk-dev] [Code Review] Cleanup bridging and features code

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/179/#review509
-----------------------------------------------------------

Ship it!


This looks good to me. All concerns noted on the bug have been addressed.

- Jeff


On 2009-03-02 09:30:55, KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/179/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 09:30:55)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a follow up to the changes made in http://reviewboard.digium.com/r/163/ plus some additional unrelated code cleanups (mostly in channel.c)
> 
> By having a dedicated timer for the features:
>   firstapss is no longer needed, because start_time is no longer shared with the features and used for the start sounds instead.
>   the backup config is no longer needed in order to disable the warnings, but the AST_FEATURE_WARNING_ACTIVE flag is used.
> The backup_config.feature_timer was actually never used - the related code is removed now.
> 
> 
> This addresses bug 14503.
>     http://bugs.digium.com/view.php?id=14503
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 179325 
>   /trunk/main/channel.c 179325 
>   /trunk/main/features.c 179325 
> 
> Diff: http://reviewboard.digium.com/r/179/diff
> 
> 
> Testing
> -------
> 
> Activating a feature, feature timeout and non feature digits are working with and without timelimit involved and also before and after a warning is played without causing unexpected warnings or delaying the next warning.
> 
> 
> Thanks,
> 
> KNK
> 
>