[asterisk-dev] [asterisk-commits] russell: branch 1.4 r179532 - /branches/1.4/apps/app_meetme.c

[Russell Bryant]

On Mar 3, 2009, at 7:14 AM, Kevin P. Fleming wrote:

> Russell Bryant wrote:
>
>> That way, if ast_read() is called at a bad time anywhere else, it  
>> will
>> definitely end up calling the channel read callback.  That will  
>> either
>> return NULL, or &ast_null_frame with an error message, IIRC,  
>> depending
>> on the channel driver.  This is better, as we'll always see a symptom
>> if this happens.
>
> Actually, I was thinking that if chan->fdno was set to -1 by  
> ast_read(),
> then any future calls to ast_read() would see that and directly
> abort/generate a warning message, without even requiring the channel
> driver callback to be involved.


Okay, yeah, that works, too.  :-)

--
Russell Bryant
Digium, Inc. | Senior Software Engineer, Open Source Team Lead
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org