[asterisk-dev] [Code Review] Convert pbx_spool to use string fields

[Russell Bryant]

> On 2009-03-02 23:52:19, Russell Bryant wrote:
> > Looks good

Also, very nice work on the summary of your last update!  This is a great example for others to follow.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/168/#review495
-----------------------------------------------------------


On 2009-03-01 16:58:44, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/168/
> -----------------------------------------------------------
> 
> (Updated 2009-03-01 16:58:44)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Simple. Convert all the static buffers used in pbx_spool to be string fields. This will dramatically lower the amount of memory used when processing a call file.
> 
> 
> Diffs
> -----
> 
>   /trunk/pbx/pbx_spool.c 179218 
> 
> Diff: http://reviewboard.digium.com/r/168/diff
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> Mark
> 
>