[asterisk-dev] [Code Review] Support for sending CDRs to syslogd
Russell Bryant
russell at digium.com
Fri Jun 26 11:41:30 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/297/#review891
-----------------------------------------------------------
/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2144>
I would use static const char CONFIG[] = "" or something similar
/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2145>
minor indentation issue
/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2147>
Initialize catg to NULl at declaration time, and you can just do ...
while ((catg = ast_category_browse(cfg, catg))) {
/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2148>
I think you missed ast_mutex_init() on the sink, and similarly, ast_mutex_destroy()
/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2151>
This is really picky, but I'd pull this back to the beginning of the line.
- Russell
On 2009-06-26 11:17:14, Sean Bright wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/297/
> -----------------------------------------------------------
>
> (Updated 2009-06-26 11:17:14)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This is the implementation of a CDR backend that allows sending CDR records to syslogd.
>
> This patch was originally written by Brett Bryant and it was a modification to cdr_custom. After some discussion I rewrote it as a separate module and added the ability to specify multiple logging destinations. The setup instructions are included in the sample configuration file.
>
>
> This addresses bug 12876.
> https://issues.asterisk.org/view.php?id=12876
>
>
> Diffs
> -----
>
> /trunk/build_tools/menuselect-deps.in 203643
> /trunk/cdr/cdr_syslog.c PRE-CREATION
> /trunk/configs/cdr_syslog.conf.sample PRE-CREATION
> /trunk/configure.ac 203643
>
> Diff: http://reviewboard.digium.com/r/297/diff
>
>
> Testing
> -------
>
> Compiles. Sent a few test calls through and they were logged successfully to multiple "sinks" defined in cdr_syslog.conf.
>
>
> Thanks,
>
> Sean
>
>
More information about the asterisk-dev
mailing list