[asterisk-dev] [Code Review] Add support for sending Reverse Charging Indication IE on ISDN PRI

[Klaus Darilion]

rmudgett at digium.com schrieb:
> ----------------------------------------------------------- This is
> an automatically generated e-mail. To reply, visit: 
> http://reviewboard.digium.com/r/292/#review880 
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Other than the items noted below, the change looks good.
> 
> Slightly off topic for this review:  You may want to change the
> receiving of the reverse charging indication to allow for the
> possibility of other enum values.  The PRI_EVENT_RING reversecharge
> value could then contain: -1 (Normal charging), 0-7.  Then chan_dahdi
> could set PRIREVERSECHARGE to the received value.  The dialplan could
> then check if PRIREVERSECHARGE is not negative for a reverse charged
> call.

I wonder why this feature is exported to dialplan using a channel 
variable? My patches on the bugtracker are not accepted if I use 
channel-variables. I was told to use dialplan-functions instead.

regards
Klaus