[asterisk-dev] [Code Review] Add support for sending Reverse Charging Indication IE on ISDN PRI

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/292/#review878
-----------------------------------------------------------


These changes are fine to add the ie the the SETUP message.  Now you need to be able to indicate that you want to do reverse charging when the SETUP is sent.  You need to add a new API function to the pri_sr_xxx() series to give the reverse charging value to libpri.  You need a new member in struct pri_sr.  Finally, you need to transfer the value to the q931_call struct in q931_setup().

Since the reverse charging ie contains a three bit field, that gives you a possible 8 enumeration values for reverse charging indications.  Only one value is defined, but I think it advisable to allow for the possibility of using the other values.  The reverse charging values sent to libpri could then be -1 (no reverse charging and the default), and 0-7.


/branches/1.4/q931.c
<http://reviewboard.digium.com/r/292/#comment2127>

    This ie needs to be sent only if you are wanting to do a reverse charge.  If you are not going to do reverse charging then the function should return zero.  For an example see how the sending complete and cause ie's are handled.


- rmudgett


On 2009-06-24 13:43:34, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/292/
> -----------------------------------------------------------
> 
> (Updated 2009-06-24 13:43:34)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> As requested by Jared, this adds the ability for LibPRI to send a Reverse Charging Indication IE within a Q931 SETUP message.
> 
> I will admit to not being a LibPRI expert, but this change seems safe enough.
> 
> 
> This addresses bug 13760.
>     http://issues.asterisk.org/view.php?id=13760
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/q931.c 885 
> 
> Diff: http://reviewboard.digium.com/r/292/diff
> 
> 
> Testing
> -------
> 
> Compilation testing only.
> 
> 
> Thanks,
> 
> Sean
> 
>