[asterisk-dev] [Code Review] MWI Message-Account URI does not contain port/transport

[David Vossel]

> On 2009-06-22 21:55:18, Russell Bryant wrote:
> > /trunk/channels/chan_sip.c, lines 11063-11069
> > <http://reviewboard.digium.com/r/288/diff/1/?file=5715#file5715line11063>
> >
> >     Section 26.2.2 of RFC 3261 specifies that transport=tls is deprecated.  I know that we had used it other places in the code, but we should avoid introducing new code that does that.
> >     
> >     It looks like "sips:alice at atlanta.com;transport=tcp" is the preferred format for when doing SIP TCP/TLS.

As we discussed earlier, I'm committing the patch as is, then following up with a patch to correct TLS URIs across all of chan_sip  


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/288/#review870
-----------------------------------------------------------


On 2009-06-22 17:46:47, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/288/
> -----------------------------------------------------------
> 
> (Updated 2009-06-22 17:46:47)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The Message-Account field in a SIP MWI NOTIFY message is used to identify the account the MWI is for.  With some endpoints (SNOM Phones in particular) this field apparently needs to be a reachable URI.  This patch adds the port number and transport type fields to the URI so non-standard ports/transports can be reached correctly. 
> 
> I looked through RFC-3842 and did not see any evidence of Message-Account being used for anything other than account identification.  Even though it may be unnecessary in most cases, I don't see how adding the port and transport fields to the URI could cause any problems.
> 
> RFC-3842
> " If the Request-URI or To header in a message-summary subscription
>    corresponds to a group or collection of individual messaging
>    accounts, the notifier MUST specify to which account the message-
>    summary body corresponds.  Note that the account URI MUST NOT be
>    delimited with angle brackets ("<" and ">").
> 
>       Message-Account: sip:alice at example.com"
> 
> 
> This addresses bug 14659.
>     https://issues.asterisk.org/view.php?id=14659
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 202357 
> 
> Diff: http://reviewboard.digium.com/r/288/diff
> 
> 
> Testing
> -------
> 
> klaus3000 initially reported this and include a patch for 1.4 which I believe was tested with a SNOM phone.  My patch is similar only it includes the transport type as well.
> 
> 
> Thanks,
> 
> David
> 
>