[asterisk-dev] [Code Review] Fix deadlock in chan_sip.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/285/#review862
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<http://reviewboard.digium.com/r/285/#comment2115>

    You could simplify things here by unconditionally unlocking and unreffing the channel after setting the value of codec. None of the rest of this function makes use of the channel.


- Mark


On 2009-06-17 13:05:05, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/285/
> -----------------------------------------------------------
> 
> (Updated 2009-06-17 13:05:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch resolves a deadlock in chan_sip caused by the channel pvt getting locked before the channel lock.  This change also fixes a race condition involving a channel variable returned by pbx_builtin_get_var_helper().
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 201093 
> 
> Diff: http://reviewboard.digium.com/r/285/diff
> 
> 
> Testing
> -------
> 
> Lightly tested in my lab environment.
> 
> 
> Thanks,
> 
> Matthew
> 
>