[asterisk-dev] upstart script [was: Re: [svn-commits] seanbright: trunk r200428 - in /trunk/contrib/upstart: ./ asterisk.upstart-0.3.9]

[Tzafrir Cohen]

On Sun, Jun 14, 2009 at 11:14:46PM -0400, Sean Bright wrote:
> Tzafrir Cohen wrote:
> > -c is needed. -f is a bit unnecessary, then. The v-s should not be
> > enabled by default. By default we want to see the important messages.
> > 
> > Where is the output of the console going to? Is it rotated?
> > 
> >> +
> >> +post-stop script
> >> +  # Might as well clean up after ourselves, too.
> >> +  rm -rf /var/run/asterisk
> > 
> > What happens if you have more than one Asterisk running?
> 
> Feel free to code up something to address these and I will commit them.
>  Thanks for the review.

Why do you need that command? rm -rf is certainly bad. You probably
meant 'rm -f /var/run/asterisk/*' . But why is it needed? Is there any
file in /var/run/asterisk that Asterisk does not run over at startup
if not deleted (e.g. in the event of a kill -9) ?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir