[asterisk-dev] [Code Review] data api gsoc2009

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/275/#review844
-----------------------------------------------------------



/trunk/include/asterisk/data.h
<http://reviewboard.digium.com/r/275/#comment2054>

    I think it would be better to use struct pointers for all register functions, as has been the tendency with all recent register functions.  This allows for future extensions without changing the API.



/trunk/include/asterisk/data.h
<http://reviewboard.digium.com/r/275/#comment2055>

    The field tokenizer, as we've discussed before, may be another handle to store here.



/trunk/include/asterisk/data.h
<http://reviewboard.digium.com/r/275/#comment2056>

    Go ahead and add 'secuser' and 'secdistrict' here.



/trunk/include/asterisk/data.h
<http://reviewboard.digium.com/r/275/#comment2057>

    This is consistent with my previous comment, but it's inconsistent with the original documentation in this file.



/trunk/include/asterisk/data.h
<http://reviewboard.digium.com/r/275/#comment2058>

    Nitpick: "<0" needs to have no spaces, or doxygen won't format it correctly.



/trunk/include/asterisk/data.h
<http://reviewboard.digium.com/r/275/#comment2059>

    Instead of _start and _stop, I think _init and _end would be more appropriate.



/trunk/main/data.c
<http://reviewboard.digium.com/r/275/#comment2060>

    At the time this gets used, it should be either defined as a macro or inline'd.


- Tilghman


On 2009-06-07 16:11:13, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/275/
> -----------------------------------------------------------
> 
> (Updated 2009-06-07 16:11:13)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This is the first review request for the Data API GSoC 2009 project.
> An architectural review is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/_private.h 199579 
>   /trunk/include/asterisk/data.h PRE-CREATION 
>   /trunk/main/asterisk.c 199579 
>   /trunk/main/data.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/275/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>