[asterisk-dev] [Code Review] Fixes SIP registry ref count error

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/282/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

During a sip reload, the list of sip_registry objects are supposed to be traversed, unlinked, and destroyed, but destruction never takes place due to a ref counting error.  This causes a memory leak when registry items are removed from sip.conf and reloaded.  While the registries are removed from the global list, they are not removed from the scheduler.  Because of this, SIP register attempts continue to be sent out for the item even though it may no longer be in the .conf.


Diffs
-----

  /trunk/channels/chan_sip.c 199818 

Diff: http://reviewboard.digium.com/r/282/diff


Testing
-------

added register in sip.conf, started Asterisk, took out of sip.conf, reloaded, no more register attempts were made and item was destroyed.


Thanks,

David