[asterisk-dev] [Code Review] Queue setting to disregard penalty on few queue members

[fredrik at liljegren.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/281/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

I've added a queue-setting to disregard members penalties when there are fewer than 'penaltymemberslimit' members in the queue.

E.G.: Setting penaltymemberslimit to 4 makes the queue disregard all members penalty levels if there are 4 or less members.

In queues that normally has many calls and many members prioritizing using penaltiy levels makes good sense. When these persons work off hours with just a few others and few calls over several hours, they can now get an even distribution during these times.

I don't know how many people wants this feature, but it's a small addition that won't disturbe anyone not using it, and it's a bothersome feature to add outside of asterisk (having some manager or other check queue membercount and removing penalty, adding it again etc...).

The patch is against trunk, but it works well for branch 1.6.0 as well. 


This addresses bug 14559.
    https://issues.asterisk.org/view.php?id=14559


Diffs
-----

  /trunk/apps/app_queue.c 199584 
  /trunk/configs/queues.conf.sample 199584 

Diff: http://reviewboard.digium.com/r/281/diff


Testing
-------

I have tested this only with realtime queues and realtime queue members. 
I have been running this now on production server (1.6.0...) for three months; it's working great, stably and predictably. 


Thanks,

fiddur