[asterisk-dev] [Code Review] data api gsoc2009

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/275/#review998
-----------------------------------------------------------


I think this needs some work.  This isn't very efficient and could lead to some very large slowdowns in the code.


/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/275/#comment2356>

    Possible memory leak of 'search' here.  Also, should output that no results are found:  either 'No such queue: %s' or 'No queues"



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/275/#comment2358>

    I'd kind of prefer if all of these names were tokenized in some way, otherwise you're massively increasing the amount of work done.  Even if you keep the present methods, there should be a tokenized version that you use for internal stuff like this.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/275/#comment2360>

    Seems like this paragraph is getting repeated thrice in the code.  Is there a way to simplify this?


- Tilghman


On 2009-07-20 16:12:43, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/275/
> -----------------------------------------------------------
> 
> (Updated 2009-07-20 16:12:43)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This is the first review request for the Data API GSoC 2009 project.
> An architectural review is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 207420 
>   /trunk/include/asterisk/_private.h 207420 
>   /trunk/include/asterisk/channel.h 207420 
>   /trunk/include/asterisk/data.h PRE-CREATION 
>   /trunk/include/asterisk/xml.h 207420 
>   /trunk/main/asterisk.c 207420 
>   /trunk/main/channel.c 207420 
>   /trunk/main/data.c PRE-CREATION 
>   /trunk/main/xml.c 207420 
>   /trunk/tests/test_data.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/275/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>