[asterisk-dev] [Code Review] Trunk implementation of fix for issue 12434

[Mark Michelson]

> On 2009-07-17 15:57:47, David Vossel wrote:
> > /trunk/channels/chan_sip.c, line 1866
> > <https://reviewboard.asterisk.org/r/313/diff/1/?file=5947#file5947line1866>
> >
> >     update this to reflect the additions in Trunk

Okay.


> On 2009-07-17 15:57:47, David Vossel wrote:
> > /trunk/channels/chan_sip.c, line 10077
> > <https://reviewboard.asterisk.org/r/313/diff/1/?file=5947#file5947line10077>
> >
> >     "Hi?" is confusing.  I don't know how to respond.  Maybe change this to "Hi, how are you?" to clarify the question mark.

Yes, this was my clever and original way to figure out if a text answer would appear in the SDP. Looks like I got a bit hasty to upload the diff before removing my debugging statements.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/313/#review988
-----------------------------------------------------------


On 2009-07-17 14:25:54, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/313/
> -----------------------------------------------------------
> 
> (Updated 2009-07-17 14:25:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> As the summary suggests, this is the trunk implementation of the fix for issue 12434. There is not much difference between this review request and https://reviewboard.asterisk.org/r/311/ . The two main differences are that trunk supports text streams, whereas 1.4 does not, and trunk will respond with a 0 port T.38 answer even with udptl_pt enabled if an accompanying audio stream is offered.
> 
> 
> This addresses bug 12434.
>     https://issues.asterisk.org/view.php?id=12434
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 206453 
> 
> Diff: https://reviewboard.asterisk.org/r/313/diff
> 
> 
> Testing
> -------
> 
> I used the same two sipp scenarios I used in review 311. I also set up a third scenario where audio and text were offered to be sure that the SDP response is appropriate.
> 
> 
> Thanks,
> 
> Mark
> 
>