[asterisk-dev] [Code Review] MALLOC_HOLD for debugging memory

[Tilghman Lesher]

> On 2009-07-13 15:51:48, Mark Michelson wrote:
> > /branches/1.4/main/astmm.c, lines 208-250
> > <https://reviewboard.asterisk.org/r/309/diff/1/?file=5925#file5925line208>
> >
> >     If you reverse the if and else conditions here, you can reduce the indentation level of the larger block by one.

Fixed.


> On 2009-07-13 15:51:48, Mark Michelson wrote:
> > /branches/1.4/main/astmm.c, lines 186-203
> > <https://reviewboard.asterisk.org/r/309/diff/1/?file=5925#file5925line186>
> >
> >     You should break from the for loop when this condition is true.

Fixed.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/309/#review966
-----------------------------------------------------------


On 2009-07-13 16:49:03, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/309/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 16:49:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> MALLOC_HOLD is an optional compile-time definition used to detect memory corruption.  It does this in a similar way to valgrind, although it does not slow down Asterisk appreciably (although the memory will grow somewhat larger than normal).
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/build_tools/cflags.xml 206144 
>   /branches/1.4/main/astmm.c 206144 
> 
> Diff: https://reviewboard.asterisk.org/r/309/diff
> 
> 
> Testing
> -------
> 
> Extensive testing with an idle system.
> 
> 
> Thanks,
> 
> Tilghman
> 
>