[asterisk-dev] [Code Review] data api gsoc2009

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/275/#review955
-----------------------------------------------------------



/trunk/include/asterisk/data.h
<https://reviewboard.asterisk.org/r/275/#comment2280>

    I really need to see some better documentation here.  What's the function do?



/trunk/include/asterisk/xml.h
<https://reviewboard.asterisk.org/r/275/#comment2281>

    Nitpick - Use \return when you aren't specifying a literal return value, otherwise this shows up as the return value being 'The'.



/trunk/main/data.c
<https://reviewboard.asterisk.org/r/275/#comment2282>

    Do these comparisons equally apply to string searches?  What about strings that contain UTF-8 characters?



/trunk/main/data.c
<https://reviewboard.asterisk.org/r/275/#comment2283>

    Seems like all of these should be ast_debug(...)


- Tilghman


On 2009-07-07 14:35:01, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/275/
> -----------------------------------------------------------
> 
> (Updated 2009-07-07 14:35:01)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This is the first review request for the Data API GSoC 2009 project.
> An architectural review is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/_private.h 205047 
>   /trunk/include/asterisk/data.h PRE-CREATION 
>   /trunk/include/asterisk/xml.h 205047 
>   /trunk/main/asterisk.c 205047 
>   /trunk/main/data.c PRE-CREATION 
>   /trunk/main/xml.c 205047 
>   /trunk/tests/test_data.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/275/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>