[asterisk-dev] [Code Review] SIP Dialog ref counting in 1.6.0

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/302/
-----------------------------------------------------------

(Updated 2009-07-07 14:41:24.284197)


Review request for Asterisk Developers and Russell Bryant.


Changes
-------

moved dialoglist deletion from __sip_destroy() to dialog_cleanup_and_destroy().


Summary
-------

This patch adds reference counting for sip dialogs into 1.6.0.

When proc_session_timer() is called from the scheduler thread it has no guarantee the session timer's dialog won't be freed from underneath it.  Now the session timer holds a reference to the dialog, preventing it from being destroyed during the middle of proc_session_timer().


This addresses bug 13623.
    https://issues.asterisk.org/view.php?id=13623


Diffs (updated)
-----

  /branches/1.6.0/channels/chan_sip.c 205047 
  /branches/1.6.0/include/asterisk/sched.h 205047 

Diff: http://reviewboard.digium.com/r/302/diff


Testing
-------

placed test calls, verified dialogs and session-timers get destroyed on hangup.


Thanks,

David