[asterisk-dev] [Code Review] Support setting and receiving Reverse Charging Indication over ISDN PRI
rmudgett at digium.com
rmudgett at digium.com
Thu Jul 2 09:00:59 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/303/#review930
-----------------------------------------------------------
Ship it!
/trunk/channels/chan_dahdi.c
<http://reviewboard.digium.com/r/303/#comment2236>
This is a bit picky. ast_copy_string is a little overkill here when a simple
buf[0] = '\0';
is all that is needed.
- rmudgett
On 2009-07-01 19:26:54, Sean Bright wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/303/
> -----------------------------------------------------------
>
> (Updated 2009-07-01 19:26:54)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This is a continuation of review 292 which added the ability to get/set Reverse Charging Indication in LibPRI. This patch adds the ability to specify RCI on the outbound leg of a PRI call, by prefixing the dialed number with a capital 'C' like:
>
> ...,Dial(DAHDI/g1/C4445556666)
>
> And to read it off an inbound channel:
>
> exten => s,1,Set(RCI=${CHANNEL(reversecharge)})
>
>
> This addresses bug 13760.
> https://issues.asterisk.org/view.php?id=13760
>
>
> Diffs
> -----
>
> /trunk/channels/chan_dahdi.c 204679
> /trunk/channels/sig_pri.h 204679
> /trunk/channels/sig_pri.c 204679
> /trunk/configs/chan_dahdi.conf.sample 204679
> /trunk/funcs/func_channel.c 204679
>
> Diff: http://reviewboard.digium.com/r/303/diff
>
>
> Testing
> -------
>
> Compilation testing only.
>
>
> Thanks,
>
> Sean
>
>
More information about the asterisk-dev
mailing list