[asterisk-dev] [Code Review] Support setting and receiving Reverse Charging Indication over ISDN PRI

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/303/#review921
-----------------------------------------------------------



/trunk/channels/chan_dahdi.c
<http://reviewboard.digium.com/r/303/#comment2228>

    The test needs to check for SIG_PRI, SIG_BRI, and SIG_BRI_PTMP.



/trunk/channels/sig_pri.h
<http://reviewboard.digium.com/r/303/#comment2226>

    This bit field is too small.  It would be better to simply make it an int.



/trunk/configs/chan_dahdi.conf.sample
<http://reviewboard.digium.com/r/303/#comment2227>

    Remove the word 'incoming' from the sentence.


- rmudgett


On 2009-07-01 15:03:48, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/303/
> -----------------------------------------------------------
> 
> (Updated 2009-07-01 15:03:48)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a continuation of review 292 which added the ability to get/set Reverse Charging Indication in LibPRI.  This patch adds the ability to specify RCI on the outbound leg of a PRI call, by prefixing the dialed number with a capital 'C' like:
> 
> ...,Dial(DAHDI/g1/C4445556666)
> 
> And to read it off an inbound channel:
> 
> exten => s,1,Set(RCI=${CHANNEL(reversecharge)}) 
> 
> 
> This addresses bug 13760.
>     https://issues.asterisk.org/view.php?id=13760
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 204649 
>   /trunk/channels/sig_pri.h 204649 
>   /trunk/channels/sig_pri.c 204649 
>   /trunk/configs/chan_dahdi.conf.sample 204649 
> 
> Diff: http://reviewboard.digium.com/r/303/diff
> 
> 
> Testing
> -------
> 
> Compilation testing only.
> 
> 
> Thanks,
> 
> Sean
> 
>