[asterisk-dev] [Code Review] added AES_ENCRYPT and AES_DECRYPT dialplan functions

[Russell Bryant]

> On 2009-01-25 11:56:23, Tilghman Lesher wrote:
> > /trunk/funcs/func_aes.c, line 36
> > <http://reviewboard.digium.com/r/128/diff/2/?file=2314#file2314line36>
> >
> >     Keep in mind that encryption and decryption algorithms can easily output NULL, comma characters, and other characters that can interfere with correct parsing.  Therefore, it's extremely important that you do something like encoding the resulting string into either hexadecimal or base64.  Hexadecimal is probably preferred, since base64 can include line feed characters.

Yeah we talked about that, and the thought was that we would leave the decision of encoding up to the user of the function.  So, usage could look like ...

${BASE64_ENCODE(${AES_ENCODE(1234567890abcdef,Russell was here)})}

Maybe we need a HEX_ENCODE function, too, then ...


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/128/#review314
-----------------------------------------------------------


On 2009-01-22 17:09:37, dvossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/128/
> -----------------------------------------------------------
> 
> (Updated 2009-01-22 17:09:37)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Mark Michelson.
> 
> 
> Summary
> -------
> 
> Allows data to be encrypted and decrypted using AES in the dialplan.  
> 
> 
> This addresses bug 0014301.
>     http://bugs.digium.com/view.php?id=0014301
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_aes.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/128/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> dvossel
> 
>