[asterisk-dev] [Code Review] properly report ast_func_read errors in getvar AMI action

Russell Bryant russell at digium.com
Wed Jan 21 05:11:02 CST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/125/#review309
-----------------------------------------------------------

Ship it!


Looks good, nice job.

- Russell


On 2009-01-15 12:07:20, awk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/125/
> -----------------------------------------------------------
> 
> (Updated 2009-01-15 12:07:20)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Fixed an issue where GetVar AMI Action would return an empty string for 'Value: ' when ast_func_read failed to read the function
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/manager.c 168609 
> 
> Diff: http://reviewboard.digium.com/r/125/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> awk
> 
>




More information about the asterisk-dev mailing list