[asterisk-dev] [Code Review] Forward port of SIP request queueing to trunk

Kevin Fleming kpfleming at digium.com
Thu Jan 8 08:26:40 CST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/123/
-----------------------------------------------------------

(Updated 2009-01-08 08:26:40.084098)


Review request for Asterisk Developers.


Changes
-------

Thanks; updated diff now handles ast_sched_add() failure.


Summary
-------

Due to the significant changes in reference count handling in chan_sip.c between 1.4 and trunk, I'd appreciate a few other pairs of eyes (with brains attached) reviewing this port of the request queueing code to ensure that refcounts are properly handled.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 167661 

Diff: http://reviewboard.digium.com/r/123/diff


Testing
-------

Compile testing only.


Thanks,

Kevin




More information about the asterisk-dev mailing list