[asterisk-dev] [Code Review] app_read does not break from prompt loop with empty string

[David Vossel]

That description wasn't supposed to be sent out.  The "I'm not sure I agree with it" part was because of the previous implementation which was never published. I simply forgot to update the description... But, with that said, I'm still not sure if I agree with the patch.  I lack the real world asterisk experience to really know how people use this app, so your feedback will greatly influence my take on it. 

~David 


----- Original Message -----
From: "Jared Smith" <jsmith at digium.com>
To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Sent: Friday, February 27, 2009 11:01:42 AM GMT -06:00 US/Canada Central
Subject: Re: [asterisk-dev] [Code Review] app_read does not break from prompt loop with empty string

> This is a community patch and I'm not sure I agree with it.  When
> multiple ampersand-delimited prompts are passed to app_read, pressing
> # (without pressing other DTMF keys) merely cycles through the prompts
> until it reaches the last one. Then it will *finally* skip that prompt
> and return to the dialplan.  It would be nice if # returned to the
> dialplan immediately without cycling through the rest of the
> prompts.  

I'm curious as to your reasons for not liking the patch, as that was my
original intention when I talked somebody (don't remember now) into
making app_read handle multiple prompts.  If you have a disagreement,
let us know what it is so it will foster some discussion!


-- 
Jared Smith
Digium, Inc. | Training Manager 




_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev