[asterisk-dev] [Code Review] app_read does not break from prompt loop with empty string

[BJ Weschke]

 I would tend to agree. I think there needs to be some way to quit out 
of all the prompts. If someone wanted to iteratively quit out of one 
prompt after another via DTMF they could achieve this via multiple 
app_reads in the DP.  The way it works now, it makes the delimited 
prompts somewhat less useful.

David Vossel wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/177/
> -----------------------------------------------------------
>
> Review request for Asterisk Developers and Russell Bryant.
>
>
> Summary
> -------
>
> This is a community patch and I'm not sure I agree with it.  When multiple ampersand-delimited prompts are passed to app_read, pressing # (without pressing other DTMF keys) merely cycles through the prompts until it reaches the last one. Then it will *finally* skip that prompt and return to the dialplan.  It would be nice if # returned to the dialplan immediately without cycling through the rest of the prompts.  
>
> in app.c, ast_app_getdata is called to stream the prompts and receive DTMF input.  ast_app_getdata receives user input from the ast_readstring function in channel.c.  When an '#' is entered, the string 
>
>
> This addresses bug 0014279.
>     http://bugs.digium.com/view.php?id=0014279
>
>
> Diffs
> -----
>
>   /trunk/main/app.c 178900 
>   /trunk/apps/app_read.c 178900 
>   /trunk/main/channel.c 178900 
>
> Diff: http://reviewboard.digium.com/r/177/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David
>
>
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>   


-- 
--
Bird's The Word Technologies, Inc.
http://www.btwtech.com/