[asterisk-dev] [Code Review] unload/load/reload support for chan_skinny

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/130/#review475
-----------------------------------------------------------


Just some formatting things.  There are several other places in this file that could use some cleaning up, but they aren't part of your patch. 


trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment1130>

    You can reduce indentation here by negating this statement and throwing in a continue instead:
    
        if (strcasecmp(d->id, temp->id) || !temp->prune || !temp->session) {
            continue;
        }



trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment1131>

    Reduce indentation.



trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/130/#comment1132>

    Reduce indentation.


- Sean


On 2009-02-21 09:09:49, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/130/
> -----------------------------------------------------------
> 
> (Updated 2009-02-21 09:09:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add load/unload/reload support for chan_skinny
> 
> 
> This addresses bug 10297.
>     http://bugs.digium.com/view.php?id=10297
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_skinny.c 171449 
> 
> Diff: http://reviewboard.digium.com/r/130/diff
> 
> 
> Testing
> -------
> 
> compiles and runs fine on OpenBSD 4.4 amd64
> 
> 
> Thanks,
> 
> Michiel
> 
>