[asterisk-dev] [Code Review] Optimizations to the stringfields API

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/165/#review461
-----------------------------------------------------------



/trunk/main/utils.c
<http://reviewboard.digium.com/r/165/#comment1105>

    In my previous comments, I pointed to a comparison in ast_string_field_index_set which I said was unnecessary due to this statement in __ast_string_field_ptr_grow. If you're going to leave that comparison in ast_string_field_index_set, then I suggest removing this section from __ast_string_field_ptr_grow since it is redundant and we know it will never be true.
    


- Mark


On 2009-02-17 19:46:36, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/165/
> -----------------------------------------------------------
> 
> (Updated 2009-02-17 19:46:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch provides a number of optimizations to the stringfields API, focused around saving (not wasting) memory whenever possible. Thanks to Mark Michelson for inspiring this work and coming up with the first two optimizations that are represented here:
> 
> Changes:
> 
> - Cleanup of some code, fix incorrect doxygen comments
> 
> - When a field is emptied or replaced with a new allocation, decrease the amount of 'active' space in the pool it was held in; if that pool reaches zero active space, and is not the current pool, then free it as it is no longer in use
> 
> - When allocating a pool, try to allocate a size that will fit in a 'standard' malloc() allocation without wasting space
> 
> - When allocating space for a field, store the amount of space in the two bytes immediately preceding the field; this eliminates the need to call strlen() on the field when overwriting it, and more importantly it 'remembers' the amount of space the field has available, even if a shorter string has been stored in it since it was allocated
> 
> - Don't automatically double the size of each successive pool allocated; it's wasteful
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stringfields.h 176840 
>   /trunk/main/utils.c 176840 
> 
> Diff: http://reviewboard.digium.com/r/165/diff
> 
> 
> Testing
> -------
> 
> Compile testing only, so far.
> 
> 
> Thanks,
> 
> Kevin
> 
>