[asterisk-dev] [Code Review] Documentation for the timing modules used in Asterisk

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/164/#review453
-----------------------------------------------------------



/trunk/doc/timing.txt
<http://reviewboard.digium.com/r/164/#comment1076>

    s/wasintroduced/was introduced/



/trunk/doc/timing.txt
<http://reviewboard.digium.com/r/164/#comment1077>

    s/it's/is/ would be slightly clearer



/trunk/doc/timing.txt
<http://reviewboard.digium.com/r/164/#comment1078>

    s/thiswriting/this writing/



/trunk/doc/timing.txt
<http://reviewboard.digium.com/r/164/#comment1079>

    I don't think this paragraph is actually correct.
    
    MeetMe conferences don't require timing, they require conference mixing, which is not provided by the modules referred to in this document.
    
    'DAHDI calls' require internal timing? I don't understand that, to be honest. If chan_dahdi is being used for calls, then DAHDI timing is available, but in any case, the timing source is not actually used for the calls.
    
    When I grep for ast_timer_open() in trunk, the only hits are in channel.c and chan_iax2.c. The latter is used for IAX2 trunking (as you've already documented), and the former is used for any purpose where a channel needs timing, which is primarily used for generators and file playback when internal_timing is enabled in asterisk.conf.
    
    This might need a more thorough analysis.



/trunk/doc/timing.txt
<http://reviewboard.digium.com/r/164/#comment1080>

    Do we really want to suggest that people modify the source to accomplish this, when the normal configuration-type solutions are so easy?


- Kevin


On 2009-02-17 13:42:16, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/164/
> -----------------------------------------------------------
> 
> (Updated 2009-02-17 13:42:16)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This provides documentation for the timing modules used in Asterisk beginning with Asterisk 1.6.1. The documentation provided here is dependent upon the work on review http://reviewboard.digium.com/r/162/ being placed into Asterisk.
> 
> This first upload is a rough draft, and I expect to hear quite a bit of feedback on how to improve it. I suspect that not everything that I've said is 100% accurate either, especially with regards to the timing tests described in the "What Asterisk Does with the Timing Interface" section.
> 
> 
> Diffs
> -----
> 
>   /trunk/doc/timing.txt PRE-CREATION 
>   /trunk/res/res_timing_dahdi.c 176252 
> 
> Diff: http://reviewboard.digium.com/r/164/diff
> 
> 
> Testing
> -------
> 
> How exactly does one test documentation?
> 
> 
> Thanks,
> 
> Mark
> 
>